Skip to content

Add unofficial Hosting.de DNS provider #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add unofficial Hosting.de DNS provider #2398

wants to merge 1 commit into from

Conversation

sivn
Copy link

@sivn sivn commented Nov 13, 2022

Requested in #1795 by @Benni-chan.

The author of no-hostingde-api explicitly stated that it's not actively maintained and may contain bugs. I marked it as experimental because of this.

It's up to the maintainer to include this one.

@nginxproxymanagerci
Copy link

CI Error:

/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
certbot-node: Pulling from jc21/nginx-full
Digest: sha256:f1026c745de39103f0b9ef04a3db74b46bf581d992dec0ad23771dd60ad19f38
Status: Image is up to date for jc21/nginx-full:certbot-node
docker.io/jc21/nginx-full:certbot-node
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 6.33s.
yarn run v1.22.19
$ /app/node_modules/.bin/eslint .

/app/global/certbot-dns-plugins.js
  297:1  error  Expected indentation of 1 tab but found 8 spaces    indent
  298:1  error  Expected indentation of 1 tab but found 8 spaces    indent
  299:1  error  Expected indentation of 2 tabs but found 16 spaces  indent
  300:1  error  Expected indentation of 2 tabs but found 16 spaces  indent
  301:1  error  Expected indentation of 2 tabs but found 16 spaces  indent
  302:1  error  Expected indentation of 2 tabs but found 16 spaces  indent
  303:1  error  Expected indentation of 2 tabs but found 16 spaces  indent
  304:1  error  Expected indentation of 2 tabs but found 16 spaces  indent
  305:1  error  Expected indentation of 1 tab but found 8 spaces    indent

✖ 9 problems (9 errors, 0 warnings)
  9 errors and 0 warnings potentially fixable with the `--fix` option.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

PR is now considered stale. If you want to keep it open, please comment 👍

@github-actions github-actions bot added the stale label Feb 5, 2024
@Schmidie64 Schmidie64 mentioned this pull request Apr 10, 2024
Closed
doenke
doenke reviewed Nov 22, 2024
View reviewed changes
global/certbot-dns-plugins.js
dependencies: '',
credentials: 'no_hostingde_api:dns_hostingde_apikey = XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX',
full_plugin_name: 'no-hostingde-api:dns-hostingde',
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it is already quite old:
The bot raises the error, because the indentation here is with spaces instead of tabs

@github-actions github-actions bot removed the stale label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doenke doenke doenke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sivn @doenke